Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve some Warnings from unit tests #575

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

juhoinkinen
Copy link
Member

Trying to resolve Warnings emitted by unit tests.

This PR resolves the DeprecationWarnings

  • by Flask: The 'script_info' argument is deprecated and will not be passed to the app factory function in Flask 2.1.
  • by pkg_resources: Creating a LegacyVersion has been deprecated and will be removed in the next major release

Note for the future: when the Annif support for Python 3.7 is eventually dropped, then the installation of the importlib-metadata package can be dropped too, as in Python 3.8+ the same functionality is provided by the importlib.metadata of the standard library.

About the remaining Warnings:

  • The three flake8 related warnings seem to have an open issue.
  • The CustomMaskWarning by TensorFlow could be resolved when TF is upgraded to v2.8 according to StackOverflow.
  • The DeprecationWarning by SciPy is raised by usage of Gensim, and have an open issue.

"The 'script_info' argument is deprecated and will not be passed to the app factory function in Flask 2.1."
…_metadata

"Creating a LegacyVersion has been deprecated and will be removed in the next major release"
@juhoinkinen juhoinkinen added this to the 0.57 milestone Feb 22, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #575 (bfb7a1a) into master (6238fb2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #575   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          84       84           
  Lines        5568     5568           
=======================================
  Hits         5539     5539           
  Misses         29       29           
Impacted Files Coverage Δ
annif/__init__.py 88.46% <100.00%> (ø)
tests/test_cli.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6238fb2...bfb7a1a. Read the comment docs.

@juhoinkinen juhoinkinen merged commit 7c9a014 into master Mar 1, 2022
@juhoinkinen juhoinkinen deleted the resolve-deprecation-warnings branch March 1, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant